Skip to content

ref(replay): Use main thread to schedule capture #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

ref(replay): Use main thread to schedule capture #4542

wants to merge 7 commits into from

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jul 7, 2025

📜 Description

  • This reworks the logic to schedule screenshot + VH capture on the main thread using Handler.postDelayed
    • We were anyway posting a message from the capturer thread to the main thread before, so this gets rid of thread context switch all the time, plus ensures we run view checks (like root.width/height) on the main thread right before we capture

A couple of replay examples with the new capture logic:

https://sentry-sdks.sentry.io/explore/replays/699aa0aff2e2496db716274d637f6a33
https://sentry-sdks.sentry.io/explore/replays/d043fb059023427b97fe54f4abf39832

💡 Motivation and Context

💚 How did you test it?

Manually

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 376.06 ms 415.75 ms 39.69 ms
Size 1.58 MiB 2.09 MiB 519.30 KiB

stefanosiano
stefanosiano reviewed Jul 11, 2025
View reviewed changes
sentry-android-replay/src/main/java/io/sentry/android/replay/util/MainLooperHandler.kt
@@ -6,7 +6,15 @@ import android.os.Looper
internal class MainLooperHandler(looper: Looper = Looper.getMainLooper()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd name it (and its references) LooperHandlerWrapper, as it's more clear that it's not just to run on the main thread, even if i think you did it just for testing

stefanosiano
stefanosiano approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
just a small renaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romtsn @stefanosiano @getsentry-bot